New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify RootPart of disconnect when disconnecting component #407 #17

Closed

megheaiulian opened this issue Nov 30, 2023 · 0 comments · Fixed by #37

Assignees

Contributor

megheaiulian commented Nov 30, 2023

When a component rendered with lit-html is disconnected we should notify the template's RootPart of the disconnect so that
its async directives get disconnected too.
On disconnect we could call removePart (https://github.com/lit/lit/blob/main/packages/lit-html/src/directive-helpers.ts#L216).

Copied from matthewp/haunted#407

Related issue: matthewp/haunted#475

megheaiulian self-assigned this

cristinecula mentioned this issue

Better integrate with lit-html to properly call directive callbacks #37

Merged

cristinecula closed this as completed in #37

github-actions bot mentioned this issue

[ci] release #38

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment