Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: turn examples into integration tests #139

Closed
backkem opened this issue Sep 14, 2018 · 3 comments
Closed

Testing: turn examples into integration tests #139

backkem opened this issue Sep 14, 2018 · 3 comments
Assignees

Comments

@backkem
Copy link
Member

backkem commented Sep 14, 2018

Turn examples into integration tests.

Design goals:

  • Use the existing examples
  • Have minimal impact on the example code E.g.: add event listeners on the existing textareas.
  • Use go test to run the tests
  • Place integration tests behind a build flag to avoid bloating unit tests (E.g.: go test github.com/pions/webrtc -tags=integration)
  • Communicate test data/results over http in order to minimize use of specialized APIs for test subjects (like a browser, node, ...).

(Moved from #120)

@backkem backkem self-assigned this Sep 14, 2018
@netwer
Copy link

netwer commented Oct 17, 2018

@backkem you did not implement the turn server yet?

@backkem
Copy link
Member Author

backkem commented Oct 17, 2018

There is a turn server at pions/turn but we didn't implement connecting to a TURN server from pions/webrtc yet. (Note that this ticket doesn't relate to TURN)

@Sean-Der
Copy link
Member

Sean-Der commented Sep 8, 2020

Moved to https://github.com/pion/webrtc/wiki/Big-Ideas

I think this is a great idea, but I don't see it moving anytime soon unfortunately :(

@Sean-Der Sean-Der closed this as completed Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants