Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve samplebuilder docs #1242

Closed
josharian opened this issue Jun 6, 2020 · 3 comments
Closed

improve samplebuilder docs #1242

josharian opened this issue Jun 6, 2020 · 3 comments
Assignees

Comments

@josharian
Copy link
Contributor

There's no indication of the units for maxLate.

It's not clear what an rtp.Depacketizer is or what a standard one might look like. What is the byte slice arg and what byte slice is it returning? The tests only show a fakeDepacketizer that is a passthrough. In my testing, a passthrough depacketizer works fine. (Should depacketizer by an option? Should it have type func instead of type interface?)

Are Push and Pop safe for concurrent use? If not, what is the intended use? (If you only Pop after Pushing, then it seems like you might lose packets unnecessarily if there is a delay in inbound packets, but maybe I misunderstand.)

@tarrencev
Copy link
Contributor

@josharian can we close this with your PR? or are further improvements necessary?

@josharian
Copy link
Contributor Author

I’m no longer using pion; I’m happy to let you decide about the best path forward for this issue.

@Sean-Der Sean-Der added this to the 3.2.0 milestone Jan 23, 2022
@Sean-Der Sean-Der removed this from the 3.2.0 milestone May 22, 2022
@Sean-Der
Copy link
Member

Sean-Der commented Apr 1, 2024

The SampleBuilder has gone through lots of changes since this issue, don't believe these apply anymore.

@Sean-Der Sean-Der closed this as not planned Won't fix, can't repro, duplicate, stale Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants