Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid inbound chucks don't cause an ABORT to be generated #103

Open
Sean-Der opened this issue Feb 1, 2020 · 1 comment
Open

Invalid inbound chucks don't cause an ABORT to be generated #103

Sean-Der opened this issue Feb 1, 2020 · 1 comment

Comments

@Sean-Der
Copy link
Member

Sean-Der commented Feb 1, 2020

handleChunk iterates each chunk and calls c.check this function returns if we should abort or not.

Right now we ignore the return value and just print. In the future we need to properly handle, and send an ABORT instead of just logging.
@Sean-Der Sean-Der mentioned this issue Feb 1, 2020
Merged
@enobufs
Copy link
Member

enobufs commented May 1, 2022

This will be addressed once #183 lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@enobufs @Sean-Der