Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packetdumper logging duplicates #85

Open
mengelbart opened this issue Dec 14, 2021 · 0 comments
Open

Packetdumper logging duplicates #85

mengelbart opened this issue Dec 14, 2021 · 0 comments

Comments

@mengelbart
Copy link
Contributor

mengelbart commented Dec 14, 2021

What did you do?

Similar to #84 the packetdumper interceptors pass pointers to rtp.Header around, which can contain byte slices if they contain extensions. These slices can be overwritten by the next incoming packet before the first one was dumped. In that case, the same (later) header extension is dumped twice. I think we can either make a deep copy of the header or format before passing the pointer on to the writer loop. I am not sure which one is more efficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant