Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Jitter buffer interceptor doesn't respect the actual packet length #255

Open
braams opened this issue Jun 4, 2024 · 0 comments · May be fixed by #257
Open

The Jitter buffer interceptor doesn't respect the actual packet length #255

braams opened this issue Jun 4, 2024 · 0 comments · May be fixed by #257
Assignees

Comments

@braams
Copy link

braams commented Jun 4, 2024

Your environment.

What did you do?

I'm trying to use jitter buffer interceptor.

What did you expect?

I expect to receive RTP packets as usual, but in correct order.

What happened?

I receive invalid RTP packets. The payload length is more than expected. The payload is filled by zeroes.

The reason

The interceptor tries to unmarshal the whole buffer and doesn't respect the actual packet length.

if err := packet.Unmarshal(buf); err != nil {

It looks like we should replace packet.Unmarshal(buf) to packet.Unmarshal(buf[:n])

@braams braams linked a pull request Jun 17, 2024 that will close this issue
@thatsnotright thatsnotright self-assigned this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants