Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote IndentationRule to standard ruleset #475

Closed
shashachu opened this issue Jun 10, 2019 · 1 comment · Fixed by #758
Closed

Promote IndentationRule to standard ruleset #475

shashachu opened this issue Jun 10, 2019 · 1 comment · Fixed by #758
Milestone

Comments

@shashachu
Copy link
Contributor

These have been in experimental for a couple releases. At Pinterest we've had the indentation rule on since its release.

@bethcutler thoughts? I believe you're using the experimental IndentationRule internally as well.

@bethcutler
Copy link
Contributor

I'm definitely in favor of promoting these to the standard ruleset. I think we would prefer not to be using the experimental ruleset... once these two rules are standardized we will move back to just the standard set.

So far we've only come across two issues with the indentation: #433 (which has been fixed) and #479 (which I've just now gotten around to adding... it's a more debatable, open-ended issue). Otherwise they've worked very well for us.

@shashachu shashachu changed the title Promote IndentationRule and ImportOrderingRule to standard ruleset Promote IndentationRule to standard ruleset Jul 17, 2019
@shashachu shashachu added this to the 0.37.0 milestone May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants