-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule: newline before "{" #458
Comments
Hi, there's not currently a way to globally disable rules but that is in the roadmap. |
Ok, but where is this roadmap? |
A high level roadmap is here: https://medium.com/@Pinterest_Engineering/pinterest-ktlint-35391a1a162f For this specific issue, I just put up a PR: #459 |
Oh, I understand. I will follow this PR. Thanks! |
@shashachu Just want to comment on this general principle of configurable: The mission statement of the project is:
Adding additional configuration like this seems to be bikeshedding and is in contradiction with the original intention of the project. |
@JLLeitschuh thanks for the feedback. I actually agree with you. But in this case we're approaching it from a perspective of trying to balance what is 'right' vs what is best for the project. When we initially talked to @shyiko he mentioned things like disallowing wildcard imports being a big point of contention, and a named reason why developers had not adopted the tool. So in his handover doc, he listed as a recommendation some sort of glob-pattern-based rule suppression file, and I agree that this is the best thing in the interest of supporting wider adoption of ktlint. I do think this is a form of bikeshedding, but by giving developers an on-off switch, we at least push the bikeshedding out of ktlint and into their own projects, if that makes sense. |
I think an on/off switch is a good happy medium Sent with GitHawk |
@CalebeRios I landed PR #503 to add support for a |
Hei, thanks a lot. I hope this release launch fast, but thanks for fast reply. |
Hello everyone, in the project I work we use
{
a line below the function signature. I would like to know if it is possible to ignore this rule through .editorConfigThe text was updated successfully, but these errors were encountered: