From 779a7782ca4d43e3c8c752713c2cccc1d67575cf Mon Sep 17 00:00:00 2001 From: Paul Dingemans Date: Tue, 11 Jun 2024 15:38:14 +0200 Subject: [PATCH] Remove sdkman (#2693) Almost every release, publishing to sdkman resulted in failures. Only a few users seems to depend on it. Closes #2692 --- .github/workflows/publish-release-build.yml | 11 +---------- documentation/release-latest/docs/install/cli.md | 5 ----- documentation/snapshot/docs/install/cli.md | 5 ----- gradle/libs.versions.toml | 1 - ktlint-cli/build.gradle.kts | 9 --------- 5 files changed, 1 insertion(+), 30 deletions(-) diff --git a/.github/workflows/publish-release-build.yml b/.github/workflows/publish-release-build.yml index b59909a438..531f4162a3 100644 --- a/.github/workflows/publish-release-build.yml +++ b/.github/workflows/publish-release-build.yml @@ -47,11 +47,10 @@ jobs: if: ${{ success() }} run: echo "version=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV - - name: Create zip for dependency managers + - name: Create zip for dependency manager(s) if: ${{ success() }} run: | cd ktlint-cli/build/run - # Doing this for Homebrew and https://github.com/sdkman/sdkman-cli/wiki/Well-formed-SDK-archives mkdir -p ktlint-${{ env.version }}/bin cp ktlint ktlint-${{ env.version }}/bin zip -rm ktlint-${{ env.version }}.zip ktlint-${{ env.version }} @@ -79,14 +78,6 @@ jobs: formula-path: Formula/k/ktlint.rb download-url: https://github.com/pinterest/ktlint/releases/download/${{ env.version }}/ktlint-${{ env.version }}.zip -# - name: Release to sdkman -# if: ${{ success() }} -# env: -# SDKMAN_KEY: ${{ secrets.SDKMAN_KEY }} -# SDKMAN_TOKEN: ${{ secrets.SDKMAN_TOKEN }} -# SDKMAN_VERSION: ${{ env.version }} -# run: ./gradlew :ktlint-cli:sdkMajorRelease - - name: Update Release documentation if: ${{ success() }} run: | diff --git a/documentation/release-latest/docs/install/cli.md b/documentation/release-latest/docs/install/cli.md index 36443fb7e7..d62ecd05e3 100644 --- a/documentation/release-latest/docs/install/cli.md +++ b/documentation/release-latest/docs/install/cli.md @@ -48,11 +48,6 @@ Install with [MacPorts](https://www.macports.org/) port install ktlint ``` -Install with [SDKMAN! on macOS and Linux](https://sdkman.io/) -```sh -sdk install ktlint -``` - On Arch Linux install package [ktlint AUR](https://aur.archlinux.org/packages/ktlint/). ## Command line usage diff --git a/documentation/snapshot/docs/install/cli.md b/documentation/snapshot/docs/install/cli.md index 36443fb7e7..d62ecd05e3 100644 --- a/documentation/snapshot/docs/install/cli.md +++ b/documentation/snapshot/docs/install/cli.md @@ -48,11 +48,6 @@ Install with [MacPorts](https://www.macports.org/) port install ktlint ``` -Install with [SDKMAN! on macOS and Linux](https://sdkman.io/) -```sh -sdk install ktlint -``` - On Arch Linux install package [ktlint AUR](https://aur.archlinux.org/packages/ktlint/). ## Command line usage diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index 17a7438cc1..db52e03d05 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -10,7 +10,6 @@ kotlinDev = "1.9.24" kotlin-jvm = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" } checksum = "org.gradle.crypto.checksum:1.4.0" shadow = "com.github.johnrengelman.shadow:8.1.1" -sdkman = "io.sdkman.vendors:3.0.0" kotlinx-binary-compatibiltiy-validator = "org.jetbrains.kotlinx.binary-compatibility-validator:0.14.0" [libraries] diff --git a/ktlint-cli/build.gradle.kts b/ktlint-cli/build.gradle.kts index 19f547920a..44ca981ecc 100644 --- a/ktlint-cli/build.gradle.kts +++ b/ktlint-cli/build.gradle.kts @@ -4,7 +4,6 @@ plugins { id("ktlint-publication-library") alias(libs.plugins.shadow) alias(libs.plugins.checksum) - alias(libs.plugins.sdkman) signing } @@ -164,11 +163,3 @@ tasks.withType().configureEach { systemProperty("ktlint-version", ktlintVersion) } } - -sdkman { - val sdkmanVersion = providers.environmentVariable("SDKMAN_VERSION").orElse(project.version.toString()) - candidate = "ktlint" - version = sdkmanVersion - url = "https://github.com/pinterest/ktlint/releases/download/$sdkmanVersion/ktlint-$sdkmanVersion.zip" - hashtag = "ktlint" -}