Uses create-react-app for the docs #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianvuerings
approved these changes
Mar 6, 2018
|
I published https://github.com/facebook/create-react-app/releases/tag/v1.1.3 |
|
@gaearon you're the best, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #13
Depends on: #41
This PR adds create-react-app to manage the build of the docs. It's a faster, better maintained version of what we had already that lets us focus more on writing great docs instead of messing with build configs.
I don't see us using this forever (I think a system like Gatsby is better in the long run) but this was an easy PR and will save some time in the meantime.
Note: I had to downgrade Jest because of an issue with how Jest resolves dependencies. It looks like it's fixed however we need to wait for CRA to update to the version with the fix. Jest 22 provided support for puppeteer, which is a shame to loose but seeing as we're not using it right now I think it's a good tradeoff.