Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set high-frequency log flushing defaults and add CLI options #32

Closed
cesconix opened this issue Aug 20, 2024 · 0 comments · Fixed by #37
Closed

Set high-frequency log flushing defaults and add CLI options #32

cesconix opened this issue Aug 20, 2024 · 0 comments · Fixed by #37
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@cesconix
Copy link
Collaborator

cesconix commented Aug 20, 2024

Implement high-frequency default values for flushInterval and batchSize in Pinorama Transport to prioritize near-instantaneous log delivery, and expose these options in the Pinorama Studio CLI.

Proposed Changes

  1. Update Pinorama Studio CLI defaults:

    • flushInterval: 100ms
    • batchSize: 10
  2. Add CLI options to Pinorama Studio:

    • --flush-interval <ms>
    • --batch-size <number>

Use Cases

Live Mode (Default)

The default configuration prioritizes live logging, which is the most common use case:

  • flushInterval: 100ms
  • batchSize: 10

Post-Mortem Analysis

For post-mortem analysis of large log files, the documentation will recommend adjusting these values. Suggested starting points (subject to user needs and system capabilities):

  • flushInterval: ~5000ms
  • batchSize: ~500

Note: Documentation will emphasize that these are recommendations and users should adjust based on their specific requirements.

@cesconix cesconix self-assigned this Aug 20, 2024
@cesconix cesconix added enhancement New feature or request good first issue Good for newcomers labels Aug 20, 2024
@cesconix cesconix removed their assignment Aug 20, 2024
@cesconix cesconix linked a pull request Aug 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant