Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: should the presence of the oauth {} or saml {} blocks imply enabled = true #43

Closed
patrickcping opened this issue Feb 7, 2023 · 2 comments

Comments

@patrickcping
Copy link
Contributor

The PingOne provider implicitly sets enabled = true flags based on the presence of the surrounding block. This allows the general configuration to be flattened into a single structure, for example, it might look like the following where oauth is enabled and saml is not:

resource "davinci_application" "use_default_flow" {
  name           = "PingOne SSO Connection"
  environment_id = var.pingone_environment_id
  oauth {
      allowed_grants                = ["authorizationCode"]
      allowed_scopes                = ["openid", "profile"]
      enabled                       = true
      enforce_signed_request_openid = false
      redirect_uris                 = ["https://auth.pingone.com/0000-0000-000/rp/callback/openid_connect"]
  }
  ...
}

This obviously deviates from the underlying API, but might be more user-friendly

@samir-gandhi
Copy link
Contributor

Aiming for a better UX is always the answer.

@samir-gandhi samir-gandhi added this to the v0.2.0 milestone Apr 21, 2023
@patrickcping patrickcping removed this from the v0.2.0 milestone Dec 29, 2023
@patrickcping
Copy link
Contributor Author

Closing as no action, waiting for updated APIs

@patrickcping patrickcping closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants