Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow Descriptions are all blank/null #314

Closed
dbryar opened this issue May 29, 2024 · 1 comment · Fixed by #319
Closed

Flow Descriptions are all blank/null #314

dbryar opened this issue May 29, 2024 · 1 comment · Fixed by #319
Assignees
Labels
status/triaged The issue/PR has completed initial triage and needs assignment type/bug Something isn't working
Milestone

Comments

@dbryar
Copy link

dbryar commented May 29, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Thank you for opening an issue. Please note that we try to keep the Terraform issue tracker reserved for bug reports and feature requests. For general usage questions, please see: https://www.terraform.io/community.html.

DaVinci Terraform provider Version

0.3.1

Terraform Version

1.4.2

Affected Resource(s)

  • davinci_flow

Terraform Configuration Files

# Copy-paste your DaVinci related Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

# Remember to replace any account/customer sensitive information in the configuration before submitting the issue

# NOTE: PLEASE DO NOT share DaVinci JSON exports publicly without encrypting files first.  DaVinci JSON exports can contain environment/tenant specific information, and may also include secrets.
resource "davinci_flow" "fingerprint_device" {
  environment_id = pingone_environment.sandbox.id
  connection_link {
    id   = data.davinci_connection.variables.id
    name = "Variables"
  }
  connection_link {
    id   = data.davinci_connection.functions.id
    name = "Functions"
  }
  connection_link {
    id   = data.davinci_connection.http.id
    name = "Http"
  }
  flow_json = ...
  description = "Check the device fingerprint and last login time to determine the number of login factors required"

Debug Output

╷
│ Error: Provider produced inconsistent result after apply
│ 
│ When applying changes to davinci_flow.fingerprint_device, provider
│ "provider[\"registry.terraform.io/pingidentity/davinci\"]" produced an
│ unexpected new value: .description: was cty.StringVal("Check the device
│ fingerprint and last login time to determine the number of login factors
│ required"), but now null.
│ 
│ This is a bug in the provider, which should be reported in the provider's
│ own issue tracker.

on every flow

Expected Behavior

Should add description to Flows

Actual Behavior

Screenshot 2024-05-29 at 12 35 49 pm

Steps to Reproduce

  1. terraform apply

Important Factoids

We were relying on flowJson.description in 0.2.x but in change to 0.3.x that was being ignored, so added a description field in the block and now we see this error message (all flows)

@dbryar dbryar added status/needs-triage The issue/PR needs initial triage type/bug Something isn't working labels May 29, 2024
@patrickcping patrickcping self-assigned this May 29, 2024
@patrickcping patrickcping added this to the v0.3.3 milestone May 30, 2024
@patrickcping
Copy link
Contributor

hey @dbryar thanks for raising! I'm still working to reproduce this issue, but I do think that if description is left undefined, falling back to the description value in the flow import is sensible. I'll line this change up for the next minor release

@patrickcping patrickcping added status/triaged The issue/PR has completed initial triage and needs assignment and removed status/needs-triage The issue/PR needs initial triage labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/triaged The issue/PR has completed initial triage and needs assignment type/bug Something isn't working
Projects
None yet
2 participants