Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/davinci_flow: include a flow_variables plan derived from the flow import JSON #308

Conversation

patrickcping
Copy link
Contributor

@patrickcping patrickcping commented May 24, 2024

Change Description

  • resource/davinci_flow: flow_variables now includes a plan derived from the flow import JSON.

Required SDK Upgrades

N/a

Testing Shell Command

TF_ACC=1 go test -v -timeout 3000s -run ^TestAccResourceFlow_ github.com/pingidentity/terraform-provider-davinci/internal/service/davinci

Testing Results

Expand Results
=== RUN   TestAccResourceFlow_RemovalDrift
=== PAUSE TestAccResourceFlow_RemovalDrift
=== RUN   TestAccResourceFlow_Basic_Clean
=== PAUSE TestAccResourceFlow_Basic_Clean
=== RUN   TestAccResourceFlow_Basic_WithBootstrap
=== PAUSE TestAccResourceFlow_Basic_WithBootstrap
=== RUN   TestAccResourceFlow_ConnectionSubflowLinks_WithMappingIDs_Clean
=== PAUSE TestAccResourceFlow_ConnectionSubflowLinks_WithMappingIDs_Clean
=== RUN   TestAccResourceFlow_ConnectionSubflowLinks_WithMappingIDs_WithBootstrap
=== PAUSE TestAccResourceFlow_ConnectionSubflowLinks_WithMappingIDs_WithBootstrap
=== RUN   TestAccResourceFlow_ConnectionSubflowLinks_WithoutMappingIDs_Clean
=== PAUSE TestAccResourceFlow_ConnectionSubflowLinks_WithoutMappingIDs_Clean
=== RUN   TestAccResourceFlow_ConnectionSubflowLinks_WithoutMappingIDs_WithBootstrap
=== PAUSE TestAccResourceFlow_ConnectionSubflowLinks_WithoutMappingIDs_WithBootstrap
=== RUN   TestAccResourceFlow_ComputeDifferences_ModifySettings
=== PAUSE TestAccResourceFlow_ComputeDifferences_ModifySettings
=== RUN   TestAccResourceFlow_ComputeDifferences_CompanyId
=== PAUSE TestAccResourceFlow_ComputeDifferences_CompanyId
=== RUN   TestAccResourceFlow_ComputeDifferences_Version
=== PAUSE TestAccResourceFlow_ComputeDifferences_Version
=== RUN   TestAccResourceFlow_ComputeDifferences_Description
=== PAUSE TestAccResourceFlow_ComputeDifferences_Description
=== RUN   TestAccResourceFlow_ComputeDifferences_AdditionalProperties
=== PAUSE TestAccResourceFlow_ComputeDifferences_AdditionalProperties
=== RUN   TestAccResourceFlow_ComputeDifferences_NewNode
=== PAUSE TestAccResourceFlow_ComputeDifferences_NewNode
=== RUN   TestAccResourceFlow_UnknownFlowString
=== PAUSE TestAccResourceFlow_UnknownFlowString
=== RUN   TestAccResourceFlow_BrokenFlow
=== PAUSE TestAccResourceFlow_BrokenFlow
=== RUN   TestAccResourceFlow_BadParameters
=== PAUSE TestAccResourceFlow_BadParameters
=== CONT  TestAccResourceFlow_RemovalDrift
=== CONT  TestAccResourceFlow_ComputeDifferences_CompanyId
=== CONT  TestAccResourceFlow_ConnectionSubflowLinks_WithMappingIDs_WithBootstrap
=== CONT  TestAccResourceFlow_BrokenFlow
=== CONT  TestAccResourceFlow_UnknownFlowString
=== CONT  TestAccResourceFlow_ComputeDifferences_Description
=== CONT  TestAccResourceFlow_Basic_Clean
=== CONT  TestAccResourceFlow_ConnectionSubflowLinks_WithoutMappingIDs_WithBootstrap
=== CONT  TestAccResourceFlow_ComputeDifferences_AdditionalProperties
=== CONT  TestAccResourceFlow_ComputeDifferences_ModifySettings
=== CONT  TestAccResourceFlow_ConnectionSubflowLinks_WithoutMappingIDs_Clean
=== CONT  TestAccResourceFlow_ComputeDifferences_Version
=== CONT  TestAccResourceFlow_BadParameters
=== CONT  TestAccResourceFlow_Basic_WithBootstrap
=== CONT  TestAccResourceFlow_ComputeDifferences_NewNode
=== CONT  TestAccResourceFlow_ConnectionSubflowLinks_WithMappingIDs_Clean
=== NAME  TestAccResourceFlow_ConnectionSubflowLinks_WithMappingIDs_WithBootstrap
    resource_flow_test.go:322: Skipping test with bootstrap config: https://github.com/pingidentity/terraform-provider-davinci/issues/266
--- SKIP: TestAccResourceFlow_ConnectionSubflowLinks_WithMappingIDs_WithBootstrap (0.01s)
=== NAME  TestAccResourceFlow_Basic_WithBootstrap
    resource_flow_test.go:179: Skipping test with bootstrap config: https://github.com/pingidentity/terraform-provider-davinci/issues/266
--- SKIP: TestAccResourceFlow_Basic_WithBootstrap (0.01s)
--- PASS: TestAccResourceFlow_BrokenFlow (189.78s)
--- PASS: TestAccResourceFlow_UnknownFlowString (242.51s)
=== NAME  TestAccResourceFlow_RemovalDrift
    resource_flow_test.go:39: Skipping step 3/4 due to SkipFunc
    resource_flow_test.go:39: Skipping step 4/4 due to SkipFunc
--- PASS: TestAccResourceFlow_RemovalDrift (256.67s)
--- PASS: TestAccResourceFlow_BadParameters (269.96s)
--- PASS: TestAccResourceFlow_ComputeDifferences_Version (281.30s)
--- PASS: TestAccResourceFlow_ComputeDifferences_AdditionalProperties (285.14s)
--- PASS: TestAccResourceFlow_ComputeDifferences_Description (286.52s)
--- PASS: TestAccResourceFlow_ComputeDifferences_NewNode (292.16s)
--- PASS: TestAccResourceFlow_ComputeDifferences_ModifySettings (296.71s)
--- PASS: TestAccResourceFlow_ComputeDifferences_CompanyId (296.79s)
--- PASS: TestAccResourceFlow_Basic_Clean (524.23s)
--- PASS: TestAccResourceFlow_ConnectionSubflowLinks_WithoutMappingIDs_Clean (529.40s)
--- PASS: TestAccResourceFlow_ConnectionSubflowLinks_WithMappingIDs_Clean (533.02s)
--- PASS: TestAccResourceFlow_ConnectionSubflowLinks_WithoutMappingIDs_WithBootstrap (899.95s)
PASS
ok      github.com/pingidentity/terraform-provider-davinci/internal/service/davinci     900.676s

@patrickcping patrickcping added the type/enhancement New feature or request label May 24, 2024
@patrickcping patrickcping added this to the v0.3.2 milestone May 24, 2024
@patrickcping patrickcping self-assigned this May 24, 2024
@patrickcping patrickcping linked an issue May 24, 2024 that may be closed by this pull request
@patrickcping patrickcping marked this pull request as ready for review May 24, 2024 11:38
@patrickcping patrickcping requested review from a team and samir-gandhi as code owners May 24, 2024 11:38
@patrickcping patrickcping merged commit a3e2d9c into main May 24, 2024
13 checks passed
@patrickcping patrickcping deleted the 299-upgrade-from-02-to-03-shows-all-variables-in-flows-being-delete branch May 24, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from 0.2 to 0.3 shows all variables in flows being delete
1 participant