Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Logger package #75

Merged
merged 29 commits into from
Feb 21, 2023
Merged

[feat] Logger package #75

merged 29 commits into from
Feb 21, 2023

Conversation

t3dotgg
Copy link
Member

@t3dotgg t3dotgg commented Feb 15, 2023

Logger that will send to both console and webui via subscriptions

Needed for W-52

@vercel
Copy link

vercel bot commented Feb 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
webhookthing-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 20, 2023 at 6:35AM (UTC)
webhookthing-marketing ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 20, 2023 at 6:35AM (UTC)

@t3dotgg
Copy link
Member Author

t3dotgg commented Feb 16, 2023

Still needs a tsconfig for the new package I think

apps/cli/cli-web/src/components/logs.tsx Outdated Show resolved Hide resolved
apps/cli/cli/src/server.ts Outdated Show resolved Hide resolved
packages/logger/src/index.ts Outdated Show resolved Hide resolved
{messages.map((message, index) => {
return (
<div key={index} className="text-sm">
{webFormat(message)}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a component, should probably be mounted as such so it can be keyed and diffed accordingly

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also worth memoizing

@t3dotgg t3dotgg merged commit c7e11f4 into main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants