Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when customer replace ${version} with 4.0.4 , download file will miss pd, tidb,tikv package. #737

Open
yilongrong opened this issue Sep 1, 2020 · 3 comments
Open

when customer replace ${version} with 4.0.4 , download file will miss pd, tidb,tikv package. #737

yilongrong opened this issue Sep 1, 2020 · 3 comments
Labels
category/usability Categorizes issue or PR as a usability enhancement. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. status/TODO Categorizes issue as we will do it. type/enhancement Categorizes issue or PR as related to an enhancement.
Milestone
Next

Comments

@yilongrong
Copy link

General Question

when customer use under command download package, if ${version} replace to 4.0.4 ,it will miss some package.
customer must use v4.0.4 to download package .
tiup mirror clone tidb-community-server-${version}-linux-amd64 ${version} --os=linux --arch=amd64
@yilongrong yilongrong added the type/question Categorizes issue as related to a question. label Sep 1, 2020
@lucklove lucklove added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. status/TODO Categorizes issue as we will do it. labels Sep 2, 2020
@lucklove
Copy link
Member

lucklove commented Sep 2, 2020

We should limit the user input of the version, which must start with a 'v'

@lonng
Copy link
Contributor

lonng commented Sep 2, 2020

@lucklove Or we add the v prefix automatically.

@lucklove lucklove added this to the v1.2.3 milestone Oct 12, 2020
@lonng lonng modified the milestones: v1.2.3, v1.3.1 Nov 4, 2020
@lucklove lucklove modified the milestones: v1.3.1, v1.3.3 Dec 29, 2020
@AstroProfundis AstroProfundis added category/usability Categorizes issue or PR as a usability enhancement. type/enhancement Categorizes issue or PR as related to an enhancement. and removed type/question Categorizes issue as related to a question. labels Mar 1, 2021
@AstroProfundis AstroProfundis modified the milestones: v1.3.3, Next Mar 1, 2021
@AstroProfundis
Copy link
Contributor

This could be as easy as to copy some code from #1009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category/usability Categorizes issue or PR as a usability enhancement. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. status/TODO Categorizes issue as we will do it. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Milestone
Next
Development

No branches or pull requests
4 participants
@AstroProfundis @lonng @lucklove @yilongrong