Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TiUP无法编辑prometheus相关配置文件,如各告警规则配置文件 #604

Closed
topbrightwen opened this issue Jul 15, 2020 · 3 comments
Labels
category/usability Categorizes issue or PR as a usability enhancement. status/TODO Categorizes issue as we will do it. type/feature-request Categorizes issue as related to a new feature.
Milestone

Comments

@topbrightwen
Copy link

TiDB升级到4.0后,改用TiUP来管理集群,但发现TiUP无法编辑prometheus相关配置文件,如各种告警规则配置文件,给管理造成很大不便,希望能增加这项功能。

@topbrightwen topbrightwen added the type/feature-request Categorizes issue as related to a new feature. label Jul 15, 2020
@lucklove lucklove added category/usability Categorizes issue or PR as a usability enhancement. status/TODO Categorizes issue as we will do it. labels Jul 15, 2020
@lucklove
Copy link
Member

I think we can add an env variable to avoid covering user-edited configs in the startup script:

if [ $DONT_COVER_CONFIG == "true" ]; do
    cp {{.DeployDir}}/bin/prometheus/*.rules.yml {{.DeployDir}}/conf/
done

The variable can be added into the systems config file as this style:

monitoring_servers:
  - host: x.x.x.x
    env:
        - DONT_COVER_CONFIG: true

@lonng What do you think about this?

@AstroProfundis AstroProfundis added this to the v1.2.0 milestone Jul 27, 2020
@lucklove
Copy link
Member

Fixed by #712

@lonng
Copy link
Contributor

lonng commented Aug 31, 2020

Fixed by #712

@lucklove Better to link the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/usability Categorizes issue or PR as a usability enhancement. status/TODO Categorizes issue as we will do it. type/feature-request Categorizes issue as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants