Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: prune will destroy pump/drainer directly after scale-in. #1850

Closed
srstack opened this issue Apr 20, 2022 · 0 comments · Fixed by #1851
Closed

cluster: prune will destroy pump/drainer directly after scale-in. #1850

srstack opened this issue Apr 20, 2022 · 0 comments · Fixed by #1851
Assignees
@srstack
Labels
type/bug Categorizes issue as related to a bug.

Comments

@srstack
Copy link
Collaborator

srstack commented Apr 20, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?

tiup cluster scale-in [pump] [drainer]
tiup cluster prune

Whether the pump/drainer is offline or not, destroy it directly.

miss continue

tiup/pkg/cluster/operation/destroy.go

Line 601 in e5b8861

if !tombstone {

  1. What did you expect to see?

wait offline

  1. What version of TiUP are you using (tiup --version)?
    1.9.4
@srstack srstack added the type/bug Categorizes issue as related to a bug. label Apr 20, 2022
@srstack srstack added this to the v1.10.0 milestone Apr 20, 2022
@srstack srstack self-assigned this Apr 20, 2022
@srstack srstack mentioned this issue Apr 20, 2022
Merged
@AstroProfundis AstroProfundis removed this from the v1.10.0 milestone Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srstack srstack

Labels
type/bug Categorizes issue as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: cluster prune will destroy pump/drainer directly after scale-in srstack/tiup
2 participants
@AstroProfundis @srstack