Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: support tiup dm playground #1622

Closed
lichunzhu opened this issue Nov 16, 2021 · 8 comments
Closed

playground: support tiup dm playground #1622

lichunzhu opened this issue Nov 16, 2021 · 8 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/feature-request Categorizes issue as related to a new feature.

Comments

@lichunzhu
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe:

For TiDB cluster users can start a tidb cluster quickly by tiup playground. But dm must deploy a complicated cluster. It's hard for users to take a try.

Describe the feature you'd like:

Support a function like tiup playground for dm cluster. For example, tiup dm playground

Why the featue is needed:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

@lichunzhu lichunzhu added the type/feature-request Categorizes issue as related to a new feature. label Nov 16, 2021
@nexustar nexustar added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 11, 2022
@dveeden
Copy link
Contributor

dveeden commented Feb 1, 2023

I was thinking about this again. I see two issues for implementing the tiup playground --dm 3 feature:

There already is a "dm" component, but that is to manage DM installations with TiUP. I don't think that makes the dm-worker and dm-master binaries available locally? How to re-use this component or avoid the collision? Create a new dm-playground component?

I think --dm 3 should give you 1 master with 3 workers. So it should start the master if the number of workers is more than one. Anything to watch out for? Or should I do something like --dm-master 1 --dm-worker 3 ? Or is something like a mode like "tikv-slim" better?

@dveeden
Copy link
Contributor

dveeden commented Feb 1, 2023

This could be implemented similar to what there is for TiCDC: tiup playground --ticdc 1 ... or as part of the dm component: tiup dm playground ...

@lichunzhu
Copy link
Contributor Author

I prefer tiup dm playground --worker 3 --master 1. tiup playground --dm-master 1 --dm-worker 3 is also okay to me. But we need to change some contraints of tiup playground.

@qqqdan
Copy link
Collaborator

qqqdan commented Feb 1, 2023

I prefer similar way as TiCDC ' tiup playground --dm-master 1 --dm-worker 3'... ,which can provide an aligned user experience

@dveeden
Copy link
Contributor

dveeden commented Feb 1, 2023

I can (try to) modify the code in my branch to do something similar to what we do for ticdc, pump, drainer, etc.

But how do I get the binaries like ~/.tiup/components/dm/{version}/dm-worker ? Or should it be ~/.tiup/components/dm-worker/{version}/dm-worker ?

https://github.com/pingcap/tiup/tree/master/doc/dev doesn't have a lot of information on how to do this unfortunately.

@bolt-leandro
Copy link

This would be a very useful feature for local testing.
For launching, I also prefer a similar way to TiCDC: tiup playground --dm-master 1 --dm-worker 3

@dveeden
Copy link
Contributor

dveeden commented Oct 31, 2024

Looking at https://github.com/pingcap/tiup/blob/master/CHANGELOG.md this might be fixed in 1.16.1 in #2465 by @GMHDBJD and @siddontang

@xhebox
Copy link
Collaborator

xhebox commented Nov 1, 2024

closed by #2465

@xhebox xhebox closed this as completed Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/feature-request Categorizes issue as related to a new feature.
Projects
None yet
Development

No branches or pull requests

6 participants