Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It would be better bypass platform check when user provides binary #1481

Closed
c4pt0r opened this issue Jul 9, 2021 · 0 comments · Fixed by #1495
Closed

It would be better bypass platform check when user provides binary #1481

c4pt0r opened this issue Jul 9, 2021 · 0 comments · Fixed by #1495
Labels
component/playground Issues about the tiup-playground component type/feature-request Categorizes issue as related to a new feature.

Comments

@c4pt0r
Copy link
Member

c4pt0r commented Jul 9, 2021 

╭─dongxu at dongxu’s MacBook Air (2) in ~/pd on master✔ 21-07-09 - 15:56:22
╰─⠠⠵ tiup playground --db.binpath ~/tidb/bin/tidb-server --kv.binpath ~/tikv/target/debug/tikv-server --pd.binpath ~/pd/bin/pd-server --tiflash 0
Starting component `playground`: /Users/dongxu/.tiup/components/playground/v1.5.2/tiup-playground --db.binpath /Users/dongxu/tidb/bin/tidb-server --kv.binpath /Users/dongxu/tikv/target/debug/tikv-server --pd.binpath /Users/dongxu/pd/bin/pd-server --tiflash 0
Error: Playground bootstrapping failed: component tidb doesn't support platform darwin/arm64
Error: run `/Users/dongxu/.tiup/components/playground/v1.5.2/tiup-playground` (wd:/Users/dongxu/.tiup/data/SceS3nO) failed: exit status 1

Bypass platform check when user provides binary, I think it's more reasonable.
@c4pt0r c4pt0r added the type/feature-request Categorizes issue as related to a new feature. label Jul 9, 2021
@AstroProfundis AstroProfundis added the component/playground Issues about the tiup-playground component label Jul 9, 2021
@AstroProfundis AstroProfundis mentioned this issue Jul 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/playground Issues about the tiup-playground component type/feature-request Categorizes issue as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

playground: ignore version check error in some cases AstroProfundis/tiup
2 participants
@AstroProfundis @c4pt0r