Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the content of 'The stable version' should follow the actual release version when a user uses 'tiup playground'. #1315

Closed
lilyjazz opened this issue Apr 18, 2021 · 1 comment · Fixed by #1318
Assignees
Labels
category/document Categorizes issue or PR as a document update. category/usability Categorizes issue or PR as a usability enhancement. component/playground Issues about the tiup-playground component type/bug Categorizes issue as related to a bug.

Comments

@lilyjazz
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?

$ tiup playground

  1. What did you expect to see?
Starting component `playground`: /root/.tiup/components/playground/v1.4.1/tiup-playground
Use the latest stable version: v5.0.0

    Specify version manually:   tiup playground <version>
    The stable version:         tiup playground v 4.0.0 
    The nightly version:        tiup playground nightly

The stable version is incorrect. 'v5.0.0' should be dispalyed.

  1. What did you see instead?
Starting component `playground`: /root/.tiup/components/playground/v1.4.1/tiup-playground
Use the latest stable version: v5.0.0

    Specify version manually:   tiup playground <version>
    The stable version:         tiup playground v4.0.0
    The nightly version:        tiup playground nightly

the content of 'The stable version' should follow the actual release version.

  1. What version of TiUP are you using (tiup --version)?
$ tiup --version
1.4.0 tiup
Go Version: go1.16.2
Git Ref: v1.4.0
GitHash: eb335e6ad9d0dc19d1c43db422cd409d62bc3cea
@lilyjazz lilyjazz added the type/bug Categorizes issue as related to a bug. label Apr 18, 2021
@lilyjazz lilyjazz changed the title the content of 'The stable version' should follow the actual release version when user use 'tiup playground'. the content of 'The stable version' should follow the actual release version when users use 'tiup playground'. Apr 18, 2021
@lilyjazz lilyjazz changed the title the content of 'The stable version' should follow the actual release version when users use 'tiup playground'. the content of 'The stable version' should follow the actual release version when a user uses 'tiup playground'. Apr 18, 2021
@AstroProfundis
Copy link
Contributor

This is a prompted example to show user how to start playground with a specified version of TiDB. So the v4.0.0 part in it is hard coded and does not reflect any actual version used.

I'll try to update the message to make it less confusing.

@AstroProfundis AstroProfundis self-assigned this Apr 19, 2021
@AstroProfundis AstroProfundis added category/document Categorizes issue or PR as a document update. category/usability Categorizes issue or PR as a usability enhancement. component/playground Issues about the tiup-playground component labels Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/document Categorizes issue or PR as a document update. category/usability Categorizes issue or PR as a usability enhancement. component/playground Issues about the tiup-playground component type/bug Categorizes issue as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants