Fix status overrided by mistake #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor1996 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
=========================================
- Coverage 87.01% 86.9% -0.12%
=========================================
Files 44 44
Lines 3251 3253 +2
=========================================
- Hits 2829 2827 -2
- Misses 422 426 +4 |
yiwu-arbug
reviewed
Nov 18, 2019
Connor1996
force-pushed
the
fix-status
branch
from
5b46314 to
fe7ffc6
Compare
|
/run-all-tests |
|
@Connor1996 merge failed. |
Signed-off-by: Connor1996 <[email protected]>
Connor1996
force-pushed
the
fix-status
branch
from
fe7ffc6 to
7316038
Compare
Signed-off-by: Connor1996 <[email protected]>
Connor1996
added
needs-cherry-pick-3.x
|
cherry pick to tikv-3.0 in PR #113 |
Connor1996
pushed a commit
that referenced
this pull request
Nov 19, 2019
* fix status override Signed-off-by: Connor1996 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
InstallOutputBlobFiles, if there is an error of finishing a blob file, Titan would delete the blob file physically. But now, the non-okay-status is overridden by the okay-result of deleting files. So in the outer place, it would rewrite blob index to LSM as usual while the blob file is actuallydeleted.