Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update scalafmt for more rules #386

Merged
merged 1 commit into from
Jul 9, 2018
Merged

update scalafmt for more rules #386

merged 1 commit into from
Jul 9, 2018

Conversation

birdstorm
Copy link
Contributor

Eliminate one TODO list

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@572a9e4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #386   +/-   ##
========================================
  Coverage          ?   55.2%           
========================================
  Files             ?     127           
  Lines             ?    5809           
  Branches          ?     863           
========================================
  Hits              ?    3207           
  Misses            ?    2311           
  Partials          ?     291

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 572a9e4...74d2ce8. Read the comment docs.

ilovesoup
ilovesoup approved these changes Jul 9, 2018
View reviewed changes
Copy link
Contributor

@ilovesoup ilovesoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilovesoup ilovesoup merged commit 4dc8769 into master Jul 9, 2018
@ilovesoup ilovesoup deleted the update_scalafmt branch July 9, 2018 06:23
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
@birdstorm @ilovesoup
update scalafmt for more rules (pingcap#386)
bd886aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilovesoup ilovesoup ilovesoup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@birdstorm @codecov-io @ilovesoup