Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TISPARK-27]Fix KV error handler logic when encounter store zero store id problem. #324

Merged
merged 4 commits into from
Apr 23, 2018
Merged

[TISPARK-27]Fix KV error handler logic when encounter store zero store id problem. #324

merged 4 commits into from
Apr 23, 2018

Conversation

Novemser
Copy link
Contributor

Related to #321

@sre-bot
Copy link
Contributor

sre-bot commented Apr 23, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@Novemser
Copy link
Contributor Author

/run-all-tests

ilovesoup
ilovesoup approved these changes Apr 23, 2018
View reviewed changes
Copy link
Contributor

@ilovesoup ilovesoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tikv-client/src/main/java/com/pingcap/tikv/operation/KVErrorHandler.java Outdated
import java.util.function.Function;

// TODO: consider refactor to Builder mode
public class KVErrorHandler<RespT> implements ErrorHandler<RespT> {
private static final Logger logger = Logger.getLogger(KVErrorHandler.class);
private static final int NO_LEADER_STORE_ID = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comment for this: when zero id will be send.

ilovesoup
ilovesoup approved these changes Apr 23, 2018
View reviewed changes
Copy link
Contributor

@ilovesoup ilovesoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilovesoup ilovesoup merged commit 36f0044 into master Apr 23, 2018
@ilovesoup ilovesoup deleted the fix_store_zero_id_retry_policy branch April 23, 2018 11:28
@Novemser Novemser restored the fix_store_zero_id_retry_policy branch April 23, 2018 12:07
Novemser added a commit that referenced this pull request Apr 25, 2018
@Novemser
[TISPARK-27]Fix KV error handler logic when encounter store zero stor…
0f9e7d8 
…e id problem. (#324)
Novemser added a commit that referenced this pull request Apr 25, 2018
@Novemser
[TISPARK-27]Fix KV error handler logic when encounter store zero stor…
bdbe583 
…e id problem. (#324)
ilovesoup pushed a commit that referenced this pull request Apr 25, 2018
@Novemser @ilovesoup
Cherry pick to 1.0 (#329)
017d439 
* [TISPARK-27]Fix KV error handler logic when encounter store zero store id problem. (#324)

* Refix stale epoch handling (#325)

* Merge master

* Adjust retry policy factor and cache invalidation (#326)

* Fix map single table (#319)

* [TISPARK-25]Improve downgrade logic and efficiency (#310)
@ilovesoup ilovesoup deleted the fix_store_zero_id_retry_policy branch April 25, 2018 12:03
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
@Novemser @ilovesoup
[TISPARK-27]Fix KV error handler logic when encounter store zero stor…
e4d5b3d 
…e id problem. (pingcap#324)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilovesoup ilovesoup ilovesoup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Novemser @sre-bot @ilovesoup