Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: generate rust code for more aggregation functions #67

Closed
wants to merge 1 commit into from

Conversation

spongedu
Copy link

Update rust proto files for support more aggregation functions. See #65 for proto/go modifications

@coocood
Copy link
Member

coocood commented Nov 25, 2017

LGTM

@breezewish
Copy link
Member

Where is the change of the protobuf file?

@coocood
Copy link
Member

coocood commented Nov 27, 2017

@breeswish
#65

@breezewish
Copy link
Member

breezewish commented Nov 27, 2017

@coocood Thanks! I found something wired. I looked at the PR your referenced, and found out that it contains changes that reverted my another PR for generated files. See #66. Are there anything that I missed?

@coocood
Copy link
Member

coocood commented Nov 27, 2017

@breeswish @spongedu
Well, there is a conflict between the two PRs.
I think we can close this one.

@coocood coocood closed this Nov 27, 2017
@breezewish
Copy link
Member

breezewish commented Nov 27, 2017

@coocood I think we need to set a repeatable environment so that every one will generate exactly the same file for the same protobuf source file. According to PR #66 and PR #65 it seems that current setup instructions in README cannot provide such guarantees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants