Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add more aggregate functions and Update README. #65

Merged
merged 2 commits into from
Nov 21, 2017

Conversation

coocood
Copy link
Member

@coocood coocood commented Nov 21, 2017

No description provided.

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated
+ `git checkout v0.5`

### Generate go and rust code.
We generate all go codes in pkg folder and rust in src folder.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/codes/code/

@coocood
Copy link
Member Author

coocood commented Nov 21, 2017

@ngaut PTAL

Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood merged commit 0d1aa84 into pingcap:master Nov 21, 2017
@coocood coocood deleted the more-agg branch November 21, 2017 03:36
spongedu added a commit to spongedu/tipb that referenced this pull request Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants