Region properties middle key #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_region_properties.
get_region_properties.
…into region-properties-middle-key
…into region-properties-middle-key
src/raftstore/store/util.rs
Outdated
| ); | ||
| } | ||
|
|
||
| if keys.is_empty() { |
There was a problem hiding this comment.
Should sort these keys here.
|
ping @huachaohuang PTAL. |
huachaohuang
previously approved these changes
Jul 4, 2018
src/raftstore/store/util.rs
Outdated
| @@ -326,6 +327,37 @@ pub fn get_region_approximate_size_cf( | |||
| Ok(size) | |||
| } | |||
|
|
|||
| /// Get the approxmiate middle key of the region. The returned key maybe | |||
| /// is timpstamped if transaction KV is used, and must start with "z". | |||
There was a problem hiding this comment.
s/timpstamped/timestamped
Connor1996
reviewed
Jul 4, 2018
| keys.extend( | ||
| props | ||
| .index_handles | ||
| .range::<[u8], _>((Excluded(start.as_slice()), Excluded(end.as_slice()))) |
There was a problem hiding this comment.
The middle key is supposed to be used for split regions. So we don't hope the key equals to region's start key or end key.
|
LGTM |
AndreMouche
reviewed
Jul 5, 2018
src/raftstore/store/util.rs
Outdated
| @@ -326,6 +327,37 @@ pub fn get_region_approximate_size_cf( | |||
| Ok(size) | |||
| } | |||
|
|
|||
| /// Get the approxmiate middle key of the region. The returned key maybe | |||
| /// is timestamped if transaction KV is used, and must start with "z". | |||
| pub fn get_region_approximate_middle_cf( | |||
There was a problem hiding this comment.
Should we point out what does middle means?
AndreMouche
reviewed
Jul 5, 2018
src/raftstore/store/util.rs
Outdated
| if keys.is_empty() { | ||
| return Ok(None); | ||
| } | ||
| let middle = (keys.len() - 1) / 2; |
There was a problem hiding this comment.
got it, but maybe we could add a comment here? @hicqu
AndreMouche
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Add 2 middle_key in region properties response so that we can use the key to split region at approximate middle.
What are the type of the changes? (mandatory)
Improvement.
How has this PR been tested? (mandatory)
make dev.
Add a few positive/negative examples (optional)
tikv-ctl output changes to: