add option: restrict rocksdb log file num #3259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -394,6 +394,7 @@ pub struct DbConfig { | |||
| pub compaction_readahead_size: ReadableSize, | |||
| pub info_log_max_size: ReadableSize, | |||
| pub info_log_roll_time: ReadableDuration, | |||
| pub info_log_keep_log_file_num: u64, | |||
There was a problem hiding this comment.
I think we can default to 10 * 1GB log files.
| @@ -171,6 +171,7 @@ fn test_serde_custom_tikv_config() { | |||
| compaction_readahead_size: ReadableSize::kb(1), | |||
| info_log_max_size: ReadableSize::kb(1), | |||
| info_log_roll_time: ReadableDuration::secs(12), | |||
| info_log_keep_log_file_num: 1000, | |||
There was a problem hiding this comment.
You may want to use a different value than the default for the test.
etc/config-template.toml
Outdated
| # If specified with non-zero value, log file will be rolled | ||
| # if it has been active longer than `log_file_time_to_roll`. | ||
| # Default: 0 (disabled) | ||
| # info-log-roll-time = "1s" |
There was a problem hiding this comment.
It should be the same as the default value.
|
/run-all-tests |
|
LGTM. Please also remember to file a PR in tidb-ansible repository, like this. |
breezewish
approved these changes
Jul 2, 2018
DorianZheng
added a commit
to DorianZheng/tikv
that referenced
this pull request
Jul 25, 2018
* add option: restrict rocksdb log file num * add test case * tune default log size and num to 1GB * 10 * add rocksdb info log options to conf template * modify initial value in conf template
huachaohuang
pushed a commit
that referenced
this pull request
Jul 26, 2018
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
* add option: restrict rocksdb log file num * add test case * tune default log size and num to 1GB * 10 * add rocksdb info log options to conf template * modify initial value in conf template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Add an option to DBConfig & RaftDBConfig to restrict the info log file num
What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
Write a test case
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
No
Does this PR affect tidb-ansible update? (mandatory)
No