-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mvcc/reader: ignore Lock when lock's type is Lock #3011
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@AndreMouche |
LGTM. |
|
AndreMouche
changed the title
mvcc/reader: return the latest commit version when lock's type is Lock
mvcc/reader: ignore Lock when lock's type is Lock
May 3, 2018
LGTM |
/run-integration-tests |
LGTM. |
Please add a description for it. |
LGTM |
disksing
approved these changes
May 7, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BusyJay
pushed a commit
to BusyJay/tikv
that referenced
this pull request
May 10, 2018
BusyJay
added a commit
that referenced
this pull request
May 10, 2018
* Open nightly feature gate for crossbeam-channel. (#2995) * mvcc/reader: ignore Lock when lock's type is Lock (#3011) * coprocessor/endpoint: show client's ip in slow log (#3002) * Show wait time and reverse scan in slow log (#3017) * Use AtomicU64 instead RwLock for tracking snapshot size. (#3020) * bump 2.0.1-beta
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we adding an index, the row will be locked with 'lock' type, which means it's not allowed to write.
But the value is not changed. We can continue to read the row without the need to return an lock error when we meet the lock.
@disksing @zhangjinpeng1987 @coocood PTAL