Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make dev compile error on Mac #2628

Merged
merged 3 commits into from
Dec 29, 2017

Conversation

blacktear23
Copy link
Contributor

Execute make dev on MacOS will got compile error message:

error[E0432]: unresolved import `std::os::linux`
   --> src/util/rocksdb/mod.rs:530:26
    |
530 |             use std::os::linux::fs::MetadataExt;
    |                          ^^^^^ Could not find `linux` in `os`

error[E0599]: no method named `st_nlink` found for type `std::fs::Metadata` in the current scope
   --> src/util/rocksdb/mod.rs:531:52
    |
531 |             assert_eq!(fs::metadata(path).unwrap().st_nlink(), nlink);
    |                                                    ^^^^^^^^
    |
    = help: items from traits can only be used if the trait is in scope
    = note: the following trait is implemented but not in scope, perhaps add a `use` for it:
            candidate #1: `use std::os::macos::fs::MetadataExt;`


error: aborting due to 2 previous errors

error: Could not compile `tikv`.

@sre-bot
Copy link
Contributor

sre-bot commented Dec 29, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UncP UncP merged commit 9f1f926 into tikv:master Dec 29, 2017
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
* Fix make dev bug on Mac: do nothing when check_hard_link
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants