Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: use try shorthand #2362

Merged
merged 2 commits into from
Oct 9, 2017
Merged

*: use try shorthand #2362

merged 2 commits into from
Oct 9, 2017

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Oct 9, 2017

close #2360.

siddontang
siddontang approved these changes Oct 9, 2017
View reviewed changes
Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BusyJay BusyJay force-pushed the busyjay/use-try-shorthand branch from 50bfcf0 to e77c7a7 Compare October 9, 2017 06:00
@siddontang
Copy link
Contributor

PTAL @overvenus @zhangjinpeng1987

overvenus
overvenus approved these changes Oct 9, 2017
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disksing
Copy link
Contributor

disksing commented Oct 9, 2017

LGTM.

@BusyJay BusyJay merged commit b5ff43c into master Oct 9, 2017
@BusyJay BusyJay deleted the busyjay/use-try-shorthand branch October 9, 2017 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@siddontang siddontang siddontang approved these changes

@disksing disksing Awaiting requested review from disksing

@zhangjinpeng87 zhangjinpeng87 Awaiting requested review from zhangjinpeng87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use ? instead of try!
4 participants
@BusyJay @siddontang @disksing @overvenus