Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coprocessor/xeval: add abs int function impl #2033

Merged
merged 5 commits into from
Jul 17, 2017

Conversation

hhkbp2
Copy link
Contributor

@hhkbp2 hhkbp2 commented Jul 13, 2017

Hi,

This PR add the implementation of math function abs_int to expression evaluator.

PTAL @XuHuaiyu @AndreMouche @lishihai9017 @andelf

@hhkbp2
Copy link
Contributor Author

hhkbp2 commented Jul 13, 2017

Related to #2024

Copy link
Member

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndreMouche
Copy link
Member

@lishihai9017 @andelf @XuHuaiyu PTAL

@hhkbp2
Copy link
Contributor Author

hhkbp2 commented Jul 17, 2017

PTAL @XuHuaiyu @lishihai9017 @andelf

@XuHuaiyu
Copy link
Contributor

LGTM

@hhkbp2 hhkbp2 merged commit 3f52e67 into master Jul 17, 2017
@hhkbp2 hhkbp2 deleted the hhkbp2/add-abs-int-function-impl branch July 17, 2017 09:44
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants