raftstore: remove uuid #1953
Merged
raftstore: remove uuid #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need to update the kvproto? |
|
PTAL @hhkbp2 @javaforfun |
ngaut
reviewed
Jun 21, 2017
src/raftstore/store/peer.rs
Outdated
| // It's ok to overflow. If there are two entries share same id, then | ||
| // there should be u64::MAX entries kept in memory in which case TiKV | ||
| // should oom already. At lease true for amd64 architect. | ||
| self.pending_reads.id_allocator = id.overflowing_add(1).0; |
There was a problem hiding this comment.
Please abstract alloc method for id allocator, and use it instead of overflowing_add.
siddontang
reviewed
Jun 22, 2017
| impl ReadIndexRequest { | ||
| fn binary_id(&self) -> &[u8] { | ||
| unsafe { | ||
| let id = &self.id as *const u64 as *const u8; |
There was a problem hiding this comment.
why not use transmute here?
There was a problem hiding this comment.
Because I need a slice rather than an array.
|
LGTM |
|
PTAL @hhkbp2 |
|
need use pingcap/kvproto#171 here? |
|
It doesn't have to be included. It will be both source and binary compatible. |
|
LGTM |
hhkbp2
approved these changes
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UUID is used for two reason in our project:
The first goal can be achieved via index + term. The second implementation is not complete and redundant request can still happen when leadership is changed or instance gets restarted. A complete correct implementation is not necessary and probably reduce performance.
Hence UUID is not necessary in our project, and sometimes it occupies a lot of CPU of scheduler thread and raftstore thread in our benches and tests. So let's remove it.