mysql/json: json_merge #1951
Merged
mysql/json: json_merge #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andelf
reviewed
Jun 21, 2017
| Json::Array(array) | ||
| } | ||
| }; | ||
| let mut left_num = suffixes.len(); |
There was a problem hiding this comment.
normally lhs & rhs will be a good name.
left_num is ambiguous
| let mut left_num = suffixes.len(); | ||
| for suffix in suffixes { | ||
| data = match (data, suffix) { | ||
| (Json::Array(mut array), Json::Array(mut sub_array)) => { |
There was a problem hiding this comment.
It seems not @andelf
| } | ||
| (obj, suffix) => { | ||
| // rule 3, 4 | ||
| let mut array = Vec::with_capacity(left_num + 1); |
| } | ||
| }; | ||
| let mut left_num = suffixes.len(); | ||
| for suffix in suffixes { |
There was a problem hiding this comment.
this is a Iterator::fold pattern
| #[test] | ||
| fn test_merge() { | ||
| let test_cases = vec
|
LGTM. |
hicqu
approved these changes
Jun 23, 2017
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR implement
JSON_MERGEfor document, related PR intidbis pingcap/tidb#3374, and the relate source file intidbishttps://github.com/pingcap/tidb/blob/master/util/types/json/functions.go#L208
@hhkbp2 @hicqu @andelf @lishihai9017 PTAL