mysql/json:support json_type #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andelf
reviewed
Jun 16, 2017
|
|
||
| use super::Json; | ||
|
|
||
| const JSON_TYPE_BOOLEAN: &[u8] = b"BOOLEAN"; |
|
LGTM |
hhkbp2
reviewed
Jun 17, 2017
| #[cfg(test)] | ||
| mod test { | ||
| use super::*; | ||
| #[test] |
There was a problem hiding this comment.
Add a blank line before attribute.
siddontang
reviewed
Jun 17, 2017
| use super::Json; | ||
|
|
||
| const JSON_TYPE_BOOLEAN: &[u8] = b"BOOLEAN"; | ||
| const JSON_TYPE_NONE: &[u8] = b"NULL"; |
There was a problem hiding this comment.
Since we only need binary in tikv. And if we use str here, it would still be converted to binary after json_type @siddontang
siddontang
reviewed
Jun 19, 2017
| const JSON_TYPE_ARRAY: &[u8] = b"ARRAY"; | ||
|
|
||
| impl Json { | ||
| pub fn json_type(&self) -> &[u8] { |
There was a problem hiding this comment.
IMO, the type should be an enum or integer, but here it is a &[u8], do we use this for comparison?
There was a problem hiding this comment.
no, it's an attribute function for json in sql: https://dev.mysql.com/doc/refman/5.7/en/json-attribute-functions.html#function_json-type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR implement
json_typeforjson. Sincetidbhaven't implementjson_typein evaluator, so we would implement this part later. The related source file intidbis (https://github.com/pingcap/tidb/blob/master/util/types/json/functions.go#L25)@andelf @hhkbp2 @hicqu @lishihai9017 PTAL