mysql/json: split compare,serde,binary into independent files #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andelf
reviewed
Jun 16, 2017
src/util/codec/mysql/json/binary.rs
Outdated
| use super::super::Result; | ||
| use std::cmp::Ordering; | ||
| use std::{self, str, f64}; | ||
| use super::{Json, ERR_CONVERT_FAILED}; |
src/util/codec/mysql/json/binary.rs
Outdated
| assert_eq!(Json::I64(2), Json::Boolean(false)); | ||
| } | ||
| } | ||
| } |
src/util/codec/mysql/json/serde.rs
Outdated
| fn from_str(s: &str) -> Result<Self, Self::Err> { | ||
| match serde_json::from_str(s) { | ||
| Ok(value) => Ok(value), | ||
| Err(e) => Err(invalid_type!("Illegal Json text:{:?}", e)), |
andelf
reviewed
Jun 20, 2017
| assert!(left < right); | ||
| } | ||
|
|
||
| assert_eq!(Json::I64(2), Json::Boolean(false)); |
There was a problem hiding this comment.
Since Json::Boolean(false) would be converted to Json::Double(2.0) when compare with an Integer. @andelf
There was a problem hiding this comment.
Here it's a natural defect of TiDB, because we treat bool as int. so if we compare bool and int, there are some incompatible cases with MySQL.
|
LGTM |
|
any update? |
|
Conflicts fixed @siddontang |
|
LGTM. |
hicqu
approved these changes
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR split
compare,serde,binaryfrom json.rs into independent files.@hhkbp2 @hicqu @lishihai9017 @andelf PTAL