raftstore: fix check pending apply #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngaut
reviewed
Jun 2, 2017
src/raftstore/store/peer.rs
Outdated
| @@ -210,6 +210,7 @@ pub struct Peer { | |||
|
|
|||
| pub tag: String, | |||
|
|
|||
| // Index of last scheduled committed raft log. | |||
| pub last_ready_idx: u64, | |||
There was a problem hiding this comment.
The name last_ready_idx makes me confused. How about last_applying_idx ?
|
LGTM, we need more review. |
|
LGTM |
iosmanthus
pushed a commit
to iosmanthus/tikv
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Ray Yan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@siddontang @hhkbp2 @javaforfun PTAL
To add a stable test, we need to figure out a way to generate a snapshot without peer and step the store whenever we want.