grpc: update grpc-rs, remove server cpupool, update config. #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disksing
changed the title
|
Now ready for review. cc @siddontang @BusyJay |
siddontang
reviewed
May 25, 2017
src/server/raft_send.rs
Outdated
| handle.spawn(client.raft() | ||
| .sink_map_err(Error::from) | ||
| let (sink, _) = client.raft(); | ||
| handle.spawn(sink.sink_map_err(Error::from) |
There was a problem hiding this comment.
Do we need the raft send worker now? Seem we can send to CQ directly?
There was a problem hiding this comment.
You are right. Working on it.
|
LGTM |
|
The RaftMessageWorker is removed. PTAL @siddontang @BusyJay |
|
LGTM |
disksing
added a commit
that referenced
this pull request
Jun 5, 2017
* add grpc_service. (#1821) * server: add a SendRunner to send raft messages to other stores. (#1837) * pd: switch to grpc-rs (#1800) * grpc: update kvproto, remove kv/coprocessor from tcp server. (#1844) * grpc: replace tcp server with grpc server. (#1850) * grpc: update grpc-rs, remove server cpupool, update config. (#1865) * *: update grpc-rs. * server: share env and cleanup old rpc. (#1867) * grpc: add metrics. (#1868) * grpc: setup concurrent stream. (#1879)
iosmanthus
pushed a commit
to iosmanthus/tikv
that referenced
this pull request
Oct 17, 2024
…ikv#1865) * kvengine: fix Shard::from_change_set & to_change_set with columnar Signed-off-by: Ray Yan <[email protected]> * add columnar and use dfs in test case Signed-off-by: Ray Yan <[email protected]> --------- Signed-off-by: Ray Yan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.