util: ignore computing size if NO_LIMIT #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BusyJay
reviewed
Apr 27, 2017
src/util/mod.rs
Outdated
| let tbls = vec![ | ||
| (vec![], NO_LIMIT, 0), | ||
| (vec![], size, 0), | ||
| (vec![e.clone(); 10], NO_LIMIT, 10), |
There was a problem hiding this comment.
Missing a case (vec![e.clone(); 10], 0, 1).
BusyJay
reviewed
Apr 27, 2017
src/util/mod.rs
Outdated
| (vec![e.clone(); 10], size + 1, 1), | ||
| (vec![e.clone(); 10], 2 * size , 2), | ||
| (vec![e.clone(); 10], 10 * size, 10), | ||
| (vec![e.clone(); 10], 10 * size + 1, 10), |
There was a problem hiding this comment.
Missing a case (vec![e.clone(); 10]; 10 * size - 1, 9).
BusyJay
reviewed
Apr 27, 2017
src/raft/raft_log.rs
Outdated
| use util; | ||
|
|
||
| pub const NO_LIMIT: u64 = u64::MAX; | ||
| pub const NO_LIMIT: u64 = util::NO_LIMIT; |
There was a problem hiding this comment.
Some places use raft NO_LIMIT, I don't want to update them now.
There was a problem hiding this comment.
Then you can use pub use util::NO_LIMIT instead.
|
PTAL @BusyJay |
BusyJay
reviewed
Apr 27, 2017
src/util/mod.rs
Outdated
| return; | ||
| pub const NO_LIMIT: u64 = u64::MAX; | ||
|
|
||
| pub fn get_limit_at_size<'a, T: Message + Clone, I: IntoIterator<Item = &'a T>>(entries: I, |
|
LGTM |
BusyJay
approved these changes
Apr 27, 2017
|
LGTM |
zhangjinpeng87
pushed a commit
that referenced
this pull request
May 17, 2017
iosmanthus
pushed a commit
to iosmanthus/tikv
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Ping Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to split #1797 and do a little improvement that ignores computing size if NO_LIMIT.
In most cases, we will use NO_LIMIT, so we can return the whole entries directly.
@BusyJay @hhkbp2 @zhangjinpeng1987