support rocksdb info log dir #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/bin/tikv-server.rs
Outdated
| @@ -325,6 +325,13 @@ fn get_rocksdb_db_option(config: &toml::Value) -> RocksdbOptions { | |||
| get_toml_int(config, "rocksdb.compaction-readahead-size", Some(0)); | |||
| opts.set_compaction_readahead_size(compaction_readahead_size as u64); | |||
|
|
|||
| let info_log_dir = get_toml_string(config, "rocksdb.info-log-dir", Some("".to_owned())); | |||
| if !info_log_dir.is_empty() { | |||
| opts.create_info_log(&info_log_dir).unwrap_or_else(|e| { | |||
There was a problem hiding this comment.
It is better to set log_file_time_to_roll or max_log_file_size rotate the LOG.
|
PTAL @zhangjinpeng1987 |
BusyJay
reviewed
Mar 31, 2017
| # RocksDB info log directory, if set, RocksDB will save the log in `info-log-dir/LOG`. | ||
| # info-log-dir = "" | ||
| # Maximal size of the info log, if new info log will be created if size is large than it. | ||
| # info-log-max-size = 0 |
There was a problem hiding this comment.
Can this be set even when info-log-dir is empty?
|
PTAL @BusyJay |
iosmanthus
pushed a commit
to iosmanthus/tikv
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Ping Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use
info-log-dirto let RocksDB save its log to other place, not in origin data storage path.But we should know that the log name is still LOG.
@andelf @BusyJay @zhangjinpeng1987