scheduler: remove mio eventloop #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
siddontang
reviewed
Mar 20, 2017
| impl<T> Sender<T> for mpsc::SyncSender<T> { | ||
| fn send(&self, t: T) -> Result<(), NotifyError<T>> { | ||
| match mpsc::SyncSender::try_send(self, t) { | ||
| Ok(()) => Ok(()), |
There was a problem hiding this comment.
any test to cover full and disconnected error?
siddontang
reviewed
Mar 20, 2017
| name: &'static str, | ||
|
|
||
| marker: PhantomData<T>, |
There was a problem hiding this comment.
To consume the generic type T.
iosmanthus
pushed a commit
to iosmanthus/tikv
that referenced
this pull request
Oct 17, 2024
…al shards (tikv#1691) Signed-off-by: hslam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr simplify the logic of scheduler by removing the mio dependency.
SendChis also refactored in this pr, so it will be also helpful for introducing mio 0.6 later.@siddontang @disksing @zhangjinpeng1987 PTAL