raftstore: schedule log gc by size #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddontang
reviewed
Nov 27, 2016
| const RAFT_LOG_GC_THRESHOLD: u64 = 50; | ||
| const RAFT_LOG_GC_LIMIT: u64 = 100000; | ||
| const RAFT_LOG_GC_COUNT_LIMIT: u64 = 100000; |
siddontang
reviewed
Nov 27, 2016
| @@ -1159,7 +1160,10 @@ impl<T: Transport, C: PdClient> Store<T, C> { | |||
| let applied_idx = peer.get_store().applied_index(); | |||
| let first_idx = peer.get_store().first_index(); | |||
| let compact_idx; | |||
| if applied_idx > first_idx && applied_idx - first_idx >= self.cfg.raft_log_gc_limit { | |||
| if applied_idx > first_idx && | |||
There was a problem hiding this comment.
add log and metric for exceeding limit.
There was a problem hiding this comment.
This is tracked by CompactLog command already.
|
Rest LGTM |
|
Ping |
|
LGTM |
|
@siddontang PTAL |
|
LGTM |
iosmanthus
pushed a commit
to iosmanthus/tikv
that referenced
this pull request
May 31, 2024
* rfstore: improve bucket reliability. Signed-off-by: Evan Zhou <[email protected]> * fix add overflow Signed-off-by: Evan Zhou <[email protected]> * skip same key update Signed-off-by: Evan Zhou <[email protected]> * add todo to remove version != 0 check Signed-off-by: Evan Zhou <[email protected]> * remove zero version check Signed-off-by: Evan Zhou <[email protected]> --------- Signed-off-by: Evan Zhou <[email protected]>
mittalrishabh
pushed a commit
to mittalrishabh/tikv
that referenced
this pull request
Nov 22, 2024
Signed-off-by: ekexium <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1337
@siddontang @hhkbp2 @zhangjinpeng1987 PTAL