raftstore: support consistency check #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BusyJay
force-pushed
the
busyjay/consistency-check
branch
from
f3105d7 to
f9646e1
Compare
|
PTAL |
|
ping |
siddontang
reviewed
Nov 28, 2016
| pub static ref REGION_HASH_COUNTER_VEC: CounterVec = | ||
| register_counter_vec!( | ||
| "tikv_raftstore_hash_total", | ||
| "Total number of raftstore has computing.", |
siddontang
reviewed
Nov 28, 2016
| @@ -165,6 +171,13 @@ fn notify_region_removed(region_id: u64, peer_id: u64, mut cmd: PendingCmd) { | |||
| cmd.call(resp); | |||
| } | |||
|
|
|||
| pub struct ConsistencyState { | |||
| pub last_check_time: Instant, | |||
| // (computed_result_or_to_be_revified, index, hash) | |||
siddontang
reviewed
Nov 28, 2016
| return; | ||
| } | ||
|
|
||
| if state.index == expected_index { |
There was a problem hiding this comment.
I think we can extract a function for both here and L1706.
siddontang
reviewed
Nov 28, 2016
| state.index = index; | ||
| state.hash = hash; | ||
|
|
||
| let mut request = RaftCmdRequest::new(); |
There was a problem hiding this comment.
why not using a new_verify_hash_request like new_compute_hash_request below?
siddontang
reviewed
Nov 28, 2016
| timer.observe_duration(); | ||
|
|
||
| let mut checksum = Vec::with_capacity(4); | ||
| checksum.write_u32::<BigEndian>(sum).unwrap(); |
There was a problem hiding this comment.
Seem that we use CRC32 for checksum, no need to use Sha1?
There was a problem hiding this comment.
Yes, to reduce the overhead.
|
Rest LGTM |
|
We should add MVCC verify later. |
hhkbp2
reviewed
Nov 28, 2016
| @@ -99,6 +102,9 @@ pub struct Config { | |||
| pub max_leader_missing_duration: Duration, | |||
|
|
|||
| pub snap_apply_batch_size: usize, | |||
|
|
|||
| // Interval (s) to check region whether the data are consistent. | |||
hhkbp2
reviewed
Nov 28, 2016
| pub static ref REGION_HASH_COUNTER_VEC: CounterVec = | ||
| register_counter_vec!( | ||
| "tikv_raftstore_hash_total", | ||
| "Total number of raftstore has computed.", |
hhkbp2
reviewed
Nov 28, 2016
| leader_lease_expired_time: Option<Timespec>, | ||
| leader_missing_time: Option<Instant>, |
There was a problem hiding this comment.
The related fields should be grouped together, such as leader_lease_expired_time and election_timeout.
hhkbp2
reviewed
Nov 28, 2016
| Some(ExecResult::ComputeHash { | ||
| region: self.region().clone(), | ||
| index: ctx.index, | ||
| // This snapshot may be hold for a long time, which may cause too many |
hhkbp2
reviewed
Nov 29, 2016
| escape(&state.hash)); | ||
| } | ||
| REGION_HASH_COUNTER_VEC.with_label_values(&["verify", "matched"]).inc(); | ||
| state.hash = vec![]; |
There was a problem hiding this comment.
It would be clearer to set and reset state.index and state.hash together every time.
There was a problem hiding this comment.
state.index does not need to be updated here.
|
Rest LGTM |
|
LGTM |
BusyJay
changed the title
mittalrishabh
pushed a commit
to mittalrishabh/tikv
that referenced
this pull request
Nov 22, 2024
Signed-off-by: crazycs520 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1123 #1286 #1314
@siddontang @hhkbp2 PTAL