make rocksdb recovery mode configurable #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BusyJay
reviewed
Sep 15, 2016
| # 1 : AbsoluteConsistency, We don't expect to find any corruption in the WAL; | ||
| # 2 : PointInTimeRecovery, Recover to point-in-time consistency; | ||
| # 3 : SkipAnyCorruptedRecords, Recovery after a disaster; | ||
| wal-recovery-mode = 2 |
There was a problem hiding this comment.
Why not use AbsoluteConsistency?
There was a problem hiding this comment.
The default is 2, I think it is ok.
| @@ -187,6 +187,15 @@ fn get_rocksdb_default_cf_option(matches: &Matches, config: &toml::Value) -> Roc | |||
| let per_level_compression = util::config::parse_rocksdb_per_level_compression(&cpl).unwrap(); | |||
| opts.compression_per_level(&per_level_compression); | |||
|
|
|||
| let rmode = get_integer_value("", | |||
There was a problem hiding this comment.
Move this to L148 seems better.
siddontang
reviewed
Sep 15, 2016
| @@ -52,6 +52,16 @@ pub fn parse_rocksdb_per_level_compression(tp: &str) | |||
| Ok(result) | |||
| } | |||
|
|
|||
| pub fn parse_rocksdb_wal_recovery_mode(mode: i64) -> Result<DBRecoveryMode, ParseConfigError> { | |||
|
CI failed, seem that we should update rocksdb version in travis too. @zhangjinpeng1987 |
|
Rest LGTM |
|
Need to merge master. |
…cksdb-recovery-mode
|
PTAL @BusyJay |
|
LGTM |
iosmanthus
pushed a commit
to iosmanthus/tikv
that referenced
this pull request
Oct 30, 2023
Signed-off-by: Ping Yu <[email protected]>
mittalrishabh
pushed a commit
to mittalrishabh/tikv
that referenced
this pull request
Nov 22, 2024
* fit get region option Signed-off-by: Cabinfever_B <[email protected]> * replace tidb Signed-off-by: Cabinfever_B <[email protected]> * replace tidb Signed-off-by: Cabinfever_B <[email protected]> --------- Signed-off-by: Cabinfever_B <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make rocksdb recovery mode configurable