Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added global index to partition_table test #11651

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Oct 11, 2024

What problem does this PR solve?

Issue Number: ref #45133

What is changed and how it works?

Added global index to partition_table test.

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.1372%. Comparing base (68c22f3) to head (1bd88eb).

Additional details and impacted files
Components Coverage Δ
cdc 59.5652% <ø> (∅)
dm 50.0250% <ø> (∅)
engine 53.2054% <ø> (-0.0170%) ⬇️
Flag Coverage Δ
unit 55.1372% <ø> (+1.9148%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11651        +/-   ##
================================================
+ Coverage   53.2223%   55.1372%   +1.9148%     
================================================
  Files           213       1002       +789     
  Lines         17720     137399    +119679     
================================================
+ Hits           9431      75758     +66327     
- Misses         7686      56090     +48404     
- Partials        603       5551      +4948     

@mjonss
Copy link
Contributor Author

mjonss commented Nov 6, 2024

/retest

@dveeden
Copy link
Contributor

dveeden commented Nov 14, 2024

The linked issue is from a different repo, I assume that's why the do-not-merge/needs-linked-issue is still there?

@mjonss
Copy link
Contributor Author

mjonss commented Nov 22, 2024

/retest

@ti-chi-bot ti-chi-bot bot added area/dm Issues or PRs related to DM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 25, 2024
@Defined2014
Copy link

/retest

1 similar comment
@mjonss
Copy link
Contributor Author

mjonss commented Nov 25, 2024

/retest

Copy link
Contributor

ti-chi-bot bot commented Nov 25, 2024

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

Copy link
Contributor

ti-chi-bot bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign charlescheung96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 25, 2024
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 25, 2024
@mjonss
Copy link
Contributor Author

mjonss commented Nov 25, 2024

@CharlesCheung96 Would you have time to review this test only PR?

@mjonss
Copy link
Contributor Author

mjonss commented Nov 25, 2024

/retest

1 similar comment
@mjonss
Copy link
Contributor Author

mjonss commented Nov 25, 2024

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants