Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: udpate OWNERS_ALIASES file #9414

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Sep 6, 2024

transfer easonn7 to BenMeadowcroft

Signed-off-by: wuhuizuo [email protected]

What problem does this PR solve?

Issue Number: ref #8966

Problem Summary:

What is changed and how it works?


Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

transfer `easonn7` to `BenMeadowcroft`

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 6, 2024
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Sep 6, 2024

/cc @yudongusa @benmeadowcroft

Copy link
Contributor

ti-chi-bot bot commented Sep 6, 2024

@wuhuizuo: GitHub didn't allow me to request PR reviews from the following users: yudongusa, benmeadowcroft.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @yudongusa @benmeadowcroft

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Sep 6, 2024

/cc @zanmato1984

@ti-chi-bot ti-chi-bot bot requested a review from zanmato1984 September 6, 2024 09:27
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, zanmato1984

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,zanmato1984]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-06 09:42:31.481562777 +0000 UTC m=+3821.221986717: ☑️ agreed by CalvinNeo.
  • 2024-09-09 04:56:40.685074681 +0000 UTC m=+245870.425498620: ☑️ agreed by zanmato1984.

@ti-chi-bot ti-chi-bot bot merged commit 0ea1cd9 into pingcap:master Sep 9, 2024
3 checks passed
@wuhuizuo wuhuizuo deleted the ci/update-owner-aliases branch September 9, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants