disagg: Fix a potential crash when shutting down (#8848)

[ti-chi-bot]

This is an automated cherry-pick of #8848

What problem does this PR solve?

Issue Number: close #8837

Problem Summary:

There is a logging about "std::exception. Code: 1001, type: std::__1::system_error, e.what() = thread::join failed: Resource deadlock avoided". Usually it is caused by a thread is trying to call join for the thread itself.

There is a chance that the task handle (shared_ptr) is being held by the background pool thread

tiflash/dbms/src/Storages/BackgroundProcessingPool.cpp

Lines 226 to 228 in 0d13f39

	TaskHandle task = tryPopTask(rng);
	if (shutdown)
	break;

And the task handle could hold a shared_ptr to UniversalPageStorageService. So there could be a chance that:

1. The main thread receive kill signal, UniversalPageStorageService::shutdown is called
2. But there is a background pool thread holding a shared_ptr of remote_checkpoint_handle, which contains a shared_ptr of UniversalPageStorageService
3. The shared_ptr of UniversalPageStorageService in the ContextShared is released
4. The background pool thread try to release to shared_ptr of remote_checkpoint_handle, which cause the shared_ptr of UniversalPageStorageService being released. But the thread is created by UniversalPageStorageService::checkpoint_pool. So the thread run into calling join on itself and causing the system_error

What is changed and how it works?

Use a weak_ptr of UniversalPageStorageService instead of shared_ptr. So that even when the remote_checkpoint_handle is still holding by the background pool thread, it won't cause the background pool thread calling join on itself. Because the share counter of UniversalPageStorageService must go down to 0 outside of the background pool thread.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Fix a potential crash when shutting down under disagg arch

[JaySon-Huang]

/run-all-tests

[JaySon-Huang]

LGTM

[JaySon-Huang]

/run-all-tests

[JaySon-Huang]

/run-all-tests

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JaySon-Huang,JinheLin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-05-07 09:03:01.214389767 +0000 UTC m=+952734.971525339: ☑️ agreed by JaySon-Huang.
• 2024-05-08 03:30:13.233335839 +0000 UTC m=+1019166.990471411: ☑️ agreed by JinheLin.

[ti-chi-bot]

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.