-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Refine execution summary with ExecutorStatisticsCollector #6995
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/// In TiFlash, a hash join's build side is finished before probe side starts, | ||
/// so the join probe side's running time does not include hash table's build time, | ||
/// when construct ExecutionSummaries, we need add the build cost to probe executor | ||
base.execution_time_ns += join_build_base.execution_time_ns; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This treatment is wrong
From https://github.com/pingcap/tiflash/pull/6995/files#diff-8afda9cf273246b0b526e551688e59abad0ac41f2803a82e1342eb15bf1c1a4bL88-L109, here also need to add the execute time of all join build streams that executed before.
…ne_execution_summary
b7762e6
to
070f3aa
Compare
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: dfa1d0a
|
/merge |
@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 05ebf5a
|
/run-unit-tests |
@ywqzzy: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: ref #5900 #6518
Problem Summary:
What is changed and how it works?
In previous implementation,
ExecutionSummaryCollector
traverse through all profilingStreams to collect local execution info.While the
ExecutorsStatisticsCollector
do the same job for mpp tracing.As a result, we can use
ExecutorsStatisticsCollector
to collect local execution info instead.The change contains:
ExecutorsStatisticsCollector
to fill execution summary.ExecutorsStatisticsCollector
to collect profile for list based executors and cop tasks.JoinImpl
to add join build time.list-based
executor (from tispark) andtree-based
executor (from tidb), add test for execution summary withplanner
andQueryBlockInterpreter
.DAGContext
to make the compile faster.Check List
Tests
Side effects
Documentation
Release note