Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TiFlash supports stale read #6459

Merged
merged 8 commits into from
Dec 16, 2022
Merged

TiFlash supports stale read #6459

merged 8 commits into from
Dec 16, 2022

Conversation

hehechen
Copy link
Contributor

@hehechen hehechen commented Dec 8, 2022

Signed-off-by: hehechen [email protected]

What problem does this PR solve?

Issue Number: close #4483

Problem Summary:

What is changed and how it works?

TiFlash supports stale raed.

  1. check safe_ts that if read_index can be skipped.
  2. use query_ts, local_query_id, server_id as the MPP query id.

Check List

Tests

  • Unit test

  • Integration test

  • Manual test (add detailed scripts or steps below)
    run CH-benCHmark with stale read
    image

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 8, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CalvinNeo
  • SeaRise

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 8, 2022
@hehechen
Copy link
Contributor Author

hehechen commented Dec 8, 2022

/run-unit-test

@hehechen hehechen force-pushed the staleread branch 4 times, most recently from b87ac94 to 35601d1 Compare December 13, 2022 16:23
@hehechen hehechen changed the title [WIP] TiFlash supports stale read TiFlash supports stale read Dec 13, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2022
dbms/src/Common/TiFlashMetrics.h Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/MPPTaskId.h Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/MPPTaskManager.h Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/LearnerRead.cpp Outdated Show resolved Hide resolved
Signed-off-by: hehechen <[email protected]>
@hehechen
Copy link
Contributor Author

/run-all-tests

@hehechen
Copy link
Contributor Author

/run-integration-test

Signed-off-by: hehechen <[email protected]>
@hehechen
Copy link
Contributor Author

/run-integration-test

dbms/src/Common/TiFlashMetrics.h Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/MPPTaskId.h Outdated Show resolved Hide resolved
dbms/src/Flash/FlashService.cpp Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/MPPTask.cpp Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/MPPTaskId.cpp Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/MPPTaskId.h Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/MinTSOScheduler.cpp Outdated Show resolved Hide resolved
metrics/grafana/tiflash_summary.json Outdated Show resolved Hide resolved
Signed-off-by: hehechen <[email protected]>
@hehechen
Copy link
Contributor Author

::mpp::TaskMeta * dispatch_req_meta = dispatch_req->mutable_meta();
dispatch_req_meta->set_start_ts(sender_target_task_start_ts);
dispatch_req_meta->set_task_id(sender_target_task_task_id);
dispatch_req_meta->set_address(batch_cop_task.store_addr);

StorageDisaggregated::buildDispatchMPPTaskRequest constructs a TaskMeta to send to tiflash storage node, I think you need to update it too.

Done.

@hehechen
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for learner read part

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 15, 2022
dbms/src/Debug/dbgFuncMisc.cpp Show resolved Hide resolved
dbms/src/Flash/Mpp/MPPTask.cpp Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/MPPTaskId.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/LearnerRead.cpp Show resolved Hide resolved
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

dbms/src/Flash/Mpp/MPPTaskManager.cpp Outdated Show resolved Hide resolved
dbms/src/Flash/Coprocessor/DAGContext.h Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/MPPTaskId.h Outdated Show resolved Hide resolved
dbms/src/Debug/dbgFuncMisc.cpp Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/MPPTaskId.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/LearnerRead.cpp Show resolved Hide resolved
Signed-off-by: hehechen <[email protected]>
@hehechen
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 15, 2022
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

metrics/grafana/tiflash_summary.json Outdated Show resolved Hide resolved
Signed-off-by: hehechen <[email protected]>
@hehechen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@hehechen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d4da0a1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 16, 2022
@ti-chi-bot
Copy link
Member

@hehechen: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Stale Read
5 participants