Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IsIPv4 function push down #5120

Closed
Willendless opened this issue Jun 10, 2022 · 4 comments · Fixed by #6773
Closed

Implement IsIPv4 function push down #5120

Willendless opened this issue Jun 10, 2022 · 4 comments · Fixed by #6773
Assignees
@AntiTopQuark
Labels
component/compute good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement. type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@Willendless
Copy link
Contributor

Feature Request

Describe the feature you'd like:

We'd like to support IsIPv4 function push down.

Teachability, Documentation, Adoption, Migration Strategy:

At least one integration test and several unit tests.
@Willendless Willendless added the type/feature-request Categorizes issue or PR as related to a new feature. label Jun 10, 2022
@Willendless Willendless mentioned this issue Jun 10, 2022
Open
@ywqzzy ywqzzy added type/enhancement The issue or PR belongs to an enhancement. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. component/compute labels Jun 13, 2022
@Willendless Willendless changed the title Call For Participation: implement IsIPv4 function push down Implement IsIPv4 function push down Jun 13, 2022
@raspberry-hu
Copy link

I want to try it. thank you @Willendless

@Willendless
Copy link
Contributor Author

/assign @raspberry-hu

@AntiTopQuark
Copy link
Contributor

i wanna try it and #5121 .These two are very similar. thank you @Willendless @ywqzzy

@AntiTopQuark
Copy link
Contributor

/assign @AntiTopQuark

@AntiTopQuark AntiTopQuark mentioned this issue Feb 7, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AntiTopQuark AntiTopQuark

Labels
component/compute good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement. type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(expr):support is_ipv4 and is_ipv6 expr to tiflash
4 participants
@ywqzzy @AntiTopQuark @Willendless @raspberry-hu